Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert machine from go dep to go mod #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afbjorklund
Copy link
Contributor

No description provided.

@afbjorklund afbjorklund changed the title Convert from go dep to go mod Convert machine from go dep to go mod Jan 17, 2021
@TheLonelyGhost
Copy link

Outside of showing the vendored packages are the exact same (except for non-golang files removed), is there any reason to include what's in the vendor/ directory at all? It seems the go.mod and go.sum files cover downloading those already.

@afbjorklund
Copy link
Contributor Author

afbjorklund commented Jan 17, 2021

In this case, that was the point... Otherwise the main reason is so that you can build using the only the tarball for one module, without having to download the internet using git. But it's not really needed in the git repository, more when making dist files or so ?

See go build -mod=vendor

https://golang.org/ref/mod#build-commands


I think podman uses vendor ?

You will also find that it is a bit picky about what is in the vendor directory. For instance, now I would get this error instead:

go: inconsistent vendoring

When using go1.15, even though it was happy with go1.11. So the next step would be to maybe lift the go version a bit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants